Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few test fixes for SciMLBase v2.0 #940

Merged
merged 2 commits into from
Oct 1, 2023
Merged

A few test fixes for SciMLBase v2.0 #940

merged 2 commits into from
Oct 1, 2023

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ErikQQY
Copy link
Member

ErikQQY commented Oct 1, 2023

I am working on the BVP remake test failings, mainly around TwoPointBVPFunction and TwoPointBVProblem construcotrs, I think it was introduced in here: SciML/SciMLBase.jl#477

@ChrisRackauckas
Copy link
Member Author

Awesome, thanks for looking into it. Yes, BVProblem remake is pretty much busted from the v2 update so someone will need to fix that up. I was just trying to get tests green again so that downstream testing can continue as normal. If you can follow this up with a test fix there that would be great.

@ChrisRackauckas ChrisRackauckas merged commit 10ba2b6 into master Oct 1, 2023
49 of 54 checks passed
@ChrisRackauckas ChrisRackauckas deleted the testfixes branch October 1, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants