Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add action for bumb version #253

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

linuxluigi
Copy link
Collaborator

Add action for bumb version

Fix #180

linuxluigi and others added 5 commits February 23, 2023 17:00
Signed-off-by: Steffen Exler <[email protected]>
Co-authored-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
@linuxluigi
Copy link
Collaborator Author

Tested on fork and works fine 🙂

@@ -0,0 +1,74 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we somehow reuse the hack/release.sh script here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks for the reminder, I forget to take a look into it. I was mostly gone through a tutorial.

Comment on lines +39 to +40
- name: Create release
run: gh release create {{ steps.tag.outputs.tag }} --verify-tag --generate-notes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand this change. The workflow should just create the tag and let the release workflow (with goreleaser) take care of creating the release with proper assets.

Comment on lines +96 to +99
svu: ## Creates a new version, args options major, minor & patch
@go run github.com/caarlos0/svu $(args) --strip-prefix > config/version.txt
@go run github.com/caarlos0/svu $(args)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have make release. Why is that needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To bumb version in worklfow based on major, minor & patch. With this is possible to bumb version from the Github Workflow UI.

Screenshot 2023-02-26 at 14 34 55

Signed-off-by: Steffen Exler <[email protected]>
Co-authored-by: Steffen Exler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate release version automatically with svu
2 participants