Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.17.z] hostgroup: new test for child group with bare metal compute resource #18016

Merged
merged 1 commit into from
Mar 28, 2025
Merged

[6.17.z] hostgroup: new test for child group with bare metal compute resource #18016

merged 1 commit into from
Mar 28, 2025

Conversation

pnovotny
Copy link
Contributor

@pnovotny pnovotny commented Mar 24, 2025 •
edited
Loading

New test coverage for SAT-20579

Test coverage for bug SAT-20579 - Unable set deploy on "bare metal" in the child hostgroup if its parent hostgroup is set to use a compute resource

This adds new test case for bug SAT-20579, which covers creation of a nested group
with Bare Metal compute resource.

Requires: SatelliteQE/airgun#1774

@pnovotny pnovotny requested review from a team as code owners March 24, 2025 12:15
@pnovotny pnovotny added the No-CherryPick PR doesnt need CherryPick to previous branches label Mar 24, 2025
@pnovotny pnovotny self-assigned this Mar 24, 2025
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_hostgroup.py -k test_positive_nested_host_group_compute_resource
airgun: 1774

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10690
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_hostgroup.py -k test_positive_nested_host_group_compute_resource --external-logging
Test Result : =========== 1 passed, 7 deselected, 10 warnings in 944.23s (0:15:44) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 24, 2025
@pnovotny pnovotny mentioned this pull request Mar 25, 2025
Merged
LadislavVasina1
LadislavVasina1 approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending @ Gauravtalreja1 comments

lhellebr
lhellebr approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@lhellebr lhellebr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also ACK pending Gaurav's comments

@pnovotny pnovotny force-pushed the 6.17.z-hg-compres-inheritance branch from 403a46c to 4482d24 Compare March 27, 2025 21:15
@pnovotny pnovotny removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 27, 2025
@pnovotny
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_hostgroup.py -k test_positive_nested_host_group_compute_resource

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10780
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_hostgroup.py -k test_positive_nested_host_group_compute_resource --external-logging
Test Result : ========== 1 passed, 7 deselected, 11 warnings in 2912.28s (0:48:32) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 27, 2025
@pnovotny
hostgroup: new test for child group with bare metal compute resource
0dab76a 
This adds new test case for bug SAT-20579, which covers creation of a nested group
with Bare Metal compute resource.
@pnovotny pnovotny force-pushed the 6.17.z-hg-compres-inheritance branch from 4482d24 to 0dab76a Compare March 27, 2025 23:45
@pnovotny
Copy link
Contributor Author

0dab76a is rebase only

@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 27, 2025
@pnovotny pnovotny added the PRT-Passed Indicates that latest PRT run is passed for the PR label Mar 27, 2025
@pondrejk pondrejk merged commit db1926d into SatelliteQE:6.17.z Mar 28, 2025
12 checks passed
@pnovotny pnovotny changed the title hostgroup: new test for child group with bare metal compute resource [6.17.z] hostgroup: new test for child group with bare metal compute resource Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@lhellebr lhellebr lhellebr approved these changes

@pondrejk pondrejk pondrejk approved these changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

Assignees

@pnovotny pnovotny

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pnovotny @Satellite-QE @lhellebr @pondrejk @Gauravtalreja1 @LadislavVasina1