🐛 Fix tests to prevent pytest from hanging #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw-in
approved these changes
Mar 11, 2022
|
@jsemearns I keep thinking this is Slackers so I put you as reviewer at first. Feel free to review though! 😉 |
Oh no I didn't think of that. It does not work ... 😣 |
lishanl
approved these changes
Mar 11, 2022
qw-in
suggested changes
Mar 12, 2022
Co-authored-by: Quinn Blenkinsop <[email protected]>
qw-in
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #94
It looks like it was some old "standard" code that I can't remember why we needed it before but I suspect that the pytest async library is now doing what the conftest file was doing before.
Locally the problem is fixed for python 3.10