Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix store domain regex #222

Merged
merged 3 commits into from
Aug 16, 2024
Merged

🐛 fix store domain regex #222

merged 3 commits into from
Aug 16, 2024

Conversation

lishanl
Copy link
Collaborator

@lishanl lishanl commented Aug 16, 2024

issue

the store_domain failed at verifying test-2-0.myshopify.com

change

  • update store_domain function to use the same regex with the domain_to_storename
  • add tests

@lishanl lishanl self-assigned this Aug 16, 2024
@lishanl lishanl requested a review from hillairet as a code owner August 16, 2024 00:02
@rahulpatidar0191 rahulpatidar0191 removed the request for review from hillairet August 16, 2024 16:44
@lishanl lishanl merged commit 3a7728a into main Aug 16, 2024
6 checks passed
@lishanl lishanl deleted the fix/store-domain-regex branch August 16, 2024 16:55
@lishanl lishanl mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulpatidar0191 rahulpatidar0191 rahulpatidar0191 approved these changes

@ponty33 ponty33 Awaiting requested review from ponty33 ponty33 is a code owner

Assignees

@lishanl lishanl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lishanl @rahulpatidar0191