Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Fix tox deployment errors #216

Merged
merged 4 commits into from
Jan 24, 2024
Merged

🚀 Fix tox deployment errors #216

merged 4 commits into from
Jan 24, 2024

Conversation

rahulpatidar0191
Copy link
Member

  • Fixes the errors we were getting when running tests
  [RuntimeError]
  The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)
  • Removed duplicate installation of tox

@rahulpatidar0191 rahulpatidar0191 added the Type: DevOps Issues related to devops label Jan 24, 2024
@rahulpatidar0191 rahulpatidar0191 self-assigned this Jan 24, 2024
lishanl
lishanl requested changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@lishanl lishanl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: let's also fix the versions fortox-gh-actions , poetry and tox to whatever are the latest now so that we don't get any unexpected failure due to their breaking changes in the future latest versions. Then we just regularly update their versions in a controlled manner.

@rahulpatidar0191
Copy link
Member Author

suggestion: let's also fix the versions fortox-gh-actions , poetry and tox to whatever are the latest now so that we don't get any unexpected failure due to their breaking changes in the future latest versions. Then we just regularly update their versions in a controlled manner.

Sure, updated tox and poetry tox-gh-actions is installed using github actions so I think it installs the latest version

lishanl
lishanl reviewed Jan 24, 2024
View reviewed changes
@lishanl
Copy link
Collaborator

lishanl commented Jan 24, 2024

Btw, this PR is to fix the poetry configuration and version mismatch when Tox runs the tests. not a deployment issue. 😄

lishanl
lishanl approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@lishanl lishanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rahul

@rahulpatidar0191
Copy link
Member Author

rahulpatidar0191 commented Jan 24, 2024 •
edited
Loading

Btw, this PR is to fix the poetry configuration and version mismatch when Tox runs the tests. not a deployment issue. 😄

It's the workflow that started this 😅

hillairet
hillairet approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@hillairet hillairet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up.

@rahulpatidar0191 rahulpatidar0191 merged commit 362c2ef into main Jan 24, 2024
6 checks passed
@rahulpatidar0191 rahulpatidar0191 deleted the fix/tox-deployment-error branch January 24, 2024 23:50
@lishanl lishanl mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hillairet hillairet hillairet approved these changes

@lishanl lishanl lishanl approved these changes

Assignees

@rahulpatidar0191 rahulpatidar0191

Labels
Type: DevOps Issues related to devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulpatidar0191 @lishanl @hillairet