Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fastapi version upper limit #94

Closed
hillairet opened this issue Mar 11, 2022 · 1 comment · Fixed by #98
Closed

Remove fastapi version upper limit #94

hillairet opened this issue Mar 11, 2022 · 1 comment · Fixed by #98
Assignees
Labels
Priority: Medium Type: Bug Something isn't working

Comments

@hillairet
Copy link
Member

hillairet commented Mar 11, 2022

For some reason the github action for python 3.9 and 3.10 would just hang if a fastapi versoion 0.69 and above was used. See #85 for the tests.

This must be related somehow to the introduction of Trio in fastapi 0.69 somehow.

@hillairet
Copy link
Member Author

Also I can reproduce it locally.

  1. Remove the upper limit on the fastapi dependency in pyproject.toml
  2. Then update the dependencies to have a fastapi > 0.68: poetry update
  3. Now just run the pytest:
poetry shell
tox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants