Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade safe-wipe and fix a few typos #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmpitzen
Copy link

@bmpitzen bmpitzen commented Mar 5, 2025

  • after an update to safe-wipe to remove a dependency on Q, this bumps the version in sassdoc
  • fixed a few typos in the Guidelines file

@bmpitzen
Copy link
Author

bmpitzen commented Mar 5, 2025

@pascalduez I see you are also a maintainer here on sassdoc. Mind taking a look at this update too?

@pascalduez
Copy link
Member

Hey @bmpitzen,

thanks for the PR, looks good to me.

Could you give us a bit more details about the issue you encounter with Q? You mentioned it's deprecated, but I'm afraid that might be true as well for most of dependencies here...
What makes me uncomfortable: we don't have a clear Node version support policy, we transpile with Babel for Node 4, but our old Travis config is set to test on Node 6, 8 and higher.
So theoretically that would be a breaking change as well, but I'm not keen on releasing a major version with only that change, given the poor maintenance state of the project, unfortunately.

First, I'll setup Github actions to be able to run the tests on PRs, that should give a tad more "confidence".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants