Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey 레이아웃 수정 #8

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Survey 레이아웃 수정 #8

merged 7 commits into from
Oct 31, 2023

Conversation

wbhaao
Copy link
Contributor

@wbhaao wbhaao commented Oct 31, 2023

작업사항

Survey UI를 예쁘게 수정했습니다!

사진

image

수정사항(선택)

@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gg-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 1:24pm

Copy link
Member

@jyh071116 jyh071116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 머지 전 수정사항 확인해주세요

Comment on lines 11 to 12
width: 14px;
height: 14px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px로 되있는 부분 %나 rem으로 변경해주세요!

width: 370px;
margin: 0 auto;
width: 470px;
margin: 60px auto 0 auto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin auto는 되도록이면 쓰지 않는 것이 좋습니다

@jyh071116 jyh071116 requested a review from d0hyun07 October 31, 2023 10:14
@jyh071116 jyh071116 added the enhancement New feature or request label Oct 31, 2023
@@ -7,14 +7,19 @@ function Home() {
<S.Container>
<S.SubTitle>2 / 2</S.SubTitle>
<S.Title>해당하는 사항에 체크해주세요</S.Title>
<form method="get" action="form-action.html">
<form>
<S.DescTitle>자신의 학력</S.DescTitle>
{exp.map((item) => (
<S.CheckLabel>
<S.Input type="radio" name="color" value="item" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value="item" 이 아니고 value={item}인 것 같습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants