Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header 레이아웃 퍼블리싱 #2

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Header 레이아웃 퍼블리싱 #2

merged 3 commits into from
Oct 30, 2023

Conversation

wbhaao
Copy link
Contributor

@wbhaao wbhaao commented Oct 30, 2023

작업사항

header 추가

사진

image

수정사항(선택)

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gg-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:05pm

Copy link
Member

@jyh071116 jyh071116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 헤더에 로고같은 요소도 있었으면 좋겠네요. 저희 프로젝트 이름인 Readable도 함꼐 넣는 건 어떨까요?

@@ -1,5 +1,6 @@
# 작업사항

header 추가
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 템플릿이라서 깃허브에 pr 올리신 뒤에 적어주시면 좋을 듯 합니다

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 사진도요

<S.Title>타이틀</S.Title>
<S.NavTitle>단어 사전</S.NavTitle>
<S.NavTitle>퀴즈</S.NavTitle>
<VscArrowLeft size={24} style={{ visibility: "hidden" }} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것도 마찬가지입니다

Comment on lines +8 to +13
<VscArrowLeft
className="arrow"
onClick={() => {}}
size={24}
style={{ color: "#3084f2" }}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모바일에서는 좌우이동보다 더 현명한 대안이 있지 않을까요? 나중에 모바일 디자인에 대해서 한 번 더 이야기해 보는 시간을 가져 봅시다

@jyh071116 jyh071116 requested a review from d0hyun07 October 30, 2023 13:55
@jyh071116 jyh071116 added the enhancement New feature or request label Oct 30, 2023
@jyh071116 jyh071116 changed the title Gyumin Header 레이아웃 퍼블리싱 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants