Parametrize sssctl tests 2. #7802
Open
+49
−324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Combine various sssctl tests to the single parametrized tests. test_sssctl__check_invalid_section_name merges tests: test_sssctl__check_missing_equal_sign test_sssctl__check_invalid_id_provider test_sssctl__check_missing_id_provider test_sssctl__check_special_character_in_option_name test_sssctl__check_special_character_in_section_name test_sssctl__check_special_character_in_domain_name test_sssctl__check_forward_slash_missing_in_domain_section test_sssctl__check_invalid_sssd_section_name test_sssctl__check_missing_closing_bracket test_sssctl__check_missing_opening_bracket Signed-off-by: Denis Karpelevich <[email protected]>
test_sssctl__check_invalid_pam_section_name (duplicate test_sssctl__check_invalid_sssd_section_name) test_sssctl__check_invalid_nss_section_name (duplicate test_sssctl__check_invalid_sssd_section_name) Signed-off-by: Denis Karpelevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_sssctl__check_invalid_section_name merges tests:
test_sssctl__check_missing_equal_sign
test_sssctl__check_invalid_id_provider
test_sssctl__check_missing_id_provider
test_sssctl__check_special_character_in_option_name test_sssctl__check_special_character_in_section_name test_sssctl__check_special_character_in_domain_name test_sssctl__check_forward_slash_missing_in_domain_section test_sssctl__check_invalid_sssd_section_name
test_sssctl__check_missing_closing_bracket
test_sssctl__check_missing_opening_bracket
Drop tests:
test_sssctl__check_invalid_pam_section_name (duplicate test_sssctl__check_invalid_sssd_section_name)
test_sssctl__check_invalid_nss_section_name (duplicate test_sssctl__check_invalid_sssd_section_name)