SSH: sss_ssh_knownhost must succeed if the responder is stopped #7785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ticket reference? |
|
None in particular. This is a reaction to the problem @danlavu faced on December 20th. I had seen this problem once or twice before. |
|
But, IIRC, previously the stance was "if one configures 'sss_ssh_knownhost' then it's also their responsibility to enable 'sssd_ssh' as well. |
|
Correct, but |
sss_ssh_knownhosts requires that SSSD's 'ssh' service is launched to
work properly. But if it is not launched or it is anyhow stopped, the
tool MUST NOT fail and let the ssh client continue its job.
:fixes: If the ssh responder is not running, `sss_ssh_knownhosts` will
not fail (but it will not return the keys).
aplopez
changed the title
alexey-tikhonov
approved these changes
Jan 9, 2025
|
ACK |
sumit-bose
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sss_ssh_knownhostsrequires that SSSD's 'ssh' service is launched to work properly. But if it is not launched or it is anyhow stopped, the tool MUST NOT fail and let the ssh client continue its job.