-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: adding client ipa trust authentication tests #7779
base: master
Are you sure you want to change the base?
Conversation
90cc21e
to
bede40a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error messages should be different to make it easy to see which exact assert failed. I wonder if it would make a sense to create tests also with authentication using su. I would not parametrize these as they would be unsightly but test_ipa_trusts__authentication_with_default_settings_su seems worth adding.
ipa_user = ipa.user("user1").add(password="Secret123").name | ||
ipa_user_fqn = f"{ipa_user}@{ipa.domain}" | ||
ad_user = trusted.user("user2").add(password="Secret123").name | ||
ad_user_fqn = f"{ad_user}@{trusted.domain}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ad, you can use ad_user_fqn = trusted.fqn("user2")
I added this fqn
method to the IPA role here https://github.com/SSSD/sssd-test-framework/pull/119/files but it won't work until merged obviously
ad_user = trusted.user("user2").add(password="Secret123").name | ||
ad_user_fqn = f"{ad_user}@{trusted.domain}" | ||
|
||
client.sssd.enable_responder("ssh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me double-check: the other IPA trust tests are using the IPA host to do the lookups; IIRC, this wasn't enabled on the client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we should update the IPA config in the framework. It's because
services = nss, pam
ad_user = trusted.user("user2").add(password="Secret123").name | ||
ad_user_fqn = f"{ad_user}@{trusted.domain}" | ||
|
||
client.sssd.enable_responder("ssh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPA was not doing that on RHEL 10 beta so we had this as a workaround. New IPA on 10.0 should include it but better to be safe.
bede40a
to
dc1414a
Compare
dc1414a
to
bfdfc67
Compare
Please fix the |
No description provided.