Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-1325 Add new swimlane for audio livesteams #536

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Jan 27, 2025

Description

For the implementation of PAC audio, this PR implements the new audio livestreams swimlane in the new page.
It shows a horizontal swimlane with square images for each radio channel logo.

Screenshot showing new radios swimlane

Changes Made

  • Add a new case liveAudioSquaredSwimlane in the SectionLayout enum
  • Return this case from the PageViewModel.layout when the mediaType is AUDIO for the contentSection
  • Call the already defined radioLivestreams(for: contentSection.vendor, contentProviders: .all) endpoint for the publisher
  • Add a new layout with a new cell (LiveRadioSquaredCell and LiveRadioSquaredCellSize)
  • Detect the new case and propagate the right calls (Content.title, Content. publisher(...), PageViewController.layoutSection(...), PageViewController.MediaCell.body)

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Jan 27, 2025
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 12:31 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 12:31 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 23:02 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square January 27, 2025 23:02 Inactive
@mutaben mutaben force-pushed the PLAYNEXT-1325-predefined-section-square branch from c6bc2e5 to d24be7f Compare January 28, 2025 19:23
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square January 28, 2025 19:30 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square January 28, 2025 21:03 Inactive
@mutaben mutaben requested a review from waliid January 29, 2025 15:04
@mutaben mutaben force-pushed the PLAYNEXT-1325-predefined-section-square branch from d24be7f to 6a652d6 Compare January 30, 2025 15:32
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square January 30, 2025 15:36 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square January 30, 2025 16:11 Inactive
Copy link
Member

@pyby pyby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check after:

  • SRGDataProvider release.
  • Missing translations. make generate-translations said all is good.

@defagos
Copy link
Member

defagos commented Jan 31, 2025

I see that @pyby has reviewed this PR. We already have a livestream tab which displays the current program on air but leads to confusion for our users (e.g. between C3 video and audio).

Would it be an opportunity to make things simpler and more obvious for our users? What will happen to the live tab audio livestreams once the audio homepage has been deployed? Will the corresponding section be removed to avoid redundant access to the same content? Will the new section be moved to the live view instead? Will both coexist?

@mutaben
Copy link
Contributor Author

mutaben commented Jan 31, 2025

Will the corresponding section be removed to avoid redundant access to the same content? Will the new section be moved to the live view instead? Will both coexist?

Would it be an opportunity to make things simpler and more obvious for our users? What will happen to the live tab audio livestreams once the audio homepage has been deployed? Will the corresponding section be removed to avoid redundant access to the same content? Will the new section be moved to the live view instead? Will both coexist?

@defagos

Those are interesting questions.

I don't know exactly what is planned for the direct tab once this new Play Audio Curation page is deployed, but those are excellent questions indeed. Since this epic reached the phase where it is refined and tickets are created, I assume those cases have been considered. Bringing @Loic-Dumas in the discussion.

@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square January 31, 2025 15:48 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square January 31, 2025 15:59 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square February 3, 2025 10:08 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square February 3, 2025 10:08 Inactive
@mutaben mutaben added this pull request to the merge queue Feb 3, 2025
@mutaben mutaben removed this pull request from the merge queue due to a manual request Feb 3, 2025
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square February 3, 2025 10:51 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square February 3, 2025 11:25 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1325-predefined-section-square February 3, 2025 20:28 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1325-predefined-section-square February 3, 2025 20:40 Inactive
@mutaben mutaben added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 88c9b3b Feb 4, 2025
4 checks passed
@mutaben mutaben deleted the PLAYNEXT-1325-predefined-section-square branch February 4, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants