-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYNEXT-1325 Add new swimlane for audio livesteams #536
Conversation
c6bc2e5
to
d24be7f
Compare
d24be7f
to
6a652d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check after:
- SRGDataProvider release.
- Missing translations.
make generate-translations
said all is good.
I see that @pyby has reviewed this PR. We already have a livestream tab which displays the current program on air but leads to confusion for our users (e.g. between C3 video and audio). Would it be an opportunity to make things simpler and more obvious for our users? What will happen to the live tab audio livestreams once the audio homepage has been deployed? Will the corresponding section be removed to avoid redundant access to the same content? Will the new section be moved to the live view instead? Will both coexist? |
Those are interesting questions. I don't know exactly what is planned for the direct tab once this new Play Audio Curation page is deployed, but those are excellent questions indeed. Since this epic reached the phase where it is refined and tickets are created, I assume those cases have been considered. Bringing @Loic-Dumas in the discussion. |
Co-authored-by: Walid Kayhal <[email protected]>
Description
For the implementation of PAC audio, this PR implements the new audio livestreams swimlane in the new page.
It shows a horizontal swimlane with square images for each radio channel logo.
Changes Made
liveAudioSquaredSwimlane
in theSectionLayout
enumPageViewModel.layout
when themediaType
isAUDIO
for thecontentSection
radioLivestreams(for: contentSection.vendor, contentProviders: .all)
endpoint for the publisherLiveRadioSquaredCell
andLiveRadioSquaredCellSize
)Content.title
,Content. publisher(...)
,PageViewController.layoutSection(...)
,PageViewController.MediaCell.body
)Checklist