Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event-receiver): add user ip #13

Merged
merged 1 commit into from
Nov 7, 2024
Merged

feat(event-receiver): add user ip #13

merged 1 commit into from
Nov 7, 2024

Conversation

amtins
Copy link
Member

@amtins amtins commented Oct 31, 2024

Description

Add the user's ip to event data, enabling detection of false positives during geoblocking.

Changes Made

  • add ip to each event

Checklist

  • I have followed the project's style and contribution guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.

Add the user's ip to event data, enabling detection of false positives during
geoblocking.

- add ip to each event
@amtins amtins requested a review from jboix October 31, 2024 16:30
@amtins amtins added the enhancement New feature or request label Oct 31, 2024
@amtins
Copy link
Member Author

amtins commented Nov 5, 2024

After a discussion with @jboix last week, this superb piece of software will undergo a small refactoring, in the near future, in order to make it testable.

Copy link
Contributor

@jboix jboix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amtins amtins added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 12bafbd Nov 7, 2024
3 checks passed
@amtins amtins deleted the feat/add_user_ip branch November 7, 2024 12:45
Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants