Add support for the decapitated final badge. #206
Conversation
| @@ -140,6 +140,40 @@ | |||
| #define MPR121_PIN_NUM_LEDS 10 | |||
| #define MPR121_PIN_NUM_SD_CD 11 | |||
|
|
|||
| #elif defined(CONFIG_SHA_BADGE_V3_LITE) | |||
There was a problem hiding this comment.
Too bad about the duplication but adding logic would make it harder to follow, so 👍
There was a problem hiding this comment.
Sure, the question is just if it'd be an improvement: removing the duplication will make the code (slightly) less straightforward.
I'm OK with removing the duplication, but it's not necessary IMHO.
There was a problem hiding this comment.
Because we see it as a different board at the moment, I think code duplication isn't really a problem. To ease some things, we could split the badge_pins.h in a badge_config_v1.h, badge_config_v2.h, badge_config_v3.h and badge_config_v3_lite.h. Then we can use diff to spot the differences between these files.
There was a problem hiding this comment.
optionally prefix the '#include "badge_config_v3.h"' with a '#define HAVE_BADGE_MPR121' or '#undef HAVE_BADGE_MPR121'
There was a problem hiding this comment.
(I wanted to rename badge_pins.h to badge_config.h a long time ago... ;) )
https://usercontent.irccloud-cdn.com/file/i4AmPkEF/1502650536.JPG