feat(ui5-li, ui5-tree-item): introduce new slot customIcon #7572
+46
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kineticjs
reviewed
Sep 13, 2023
packages/main/src/ListItem.ts
Outdated
| @@ -498,6 +510,10 @@ abstract class ListItem extends ListItemBase { | |||
| return !!this.deleteButton.length; | |||
| } | |||
|
|
|||
| get hasIconSlot() { | |||
There was a problem hiding this comment.
minor:
"hasCustomIcon" is probably a more specific name...
But feel free to either reflect or discard this comment
(I see that the convention hasXslot is already used in the file => I guess this is why you used that pattern, even though its name is not literally 100% accurate)
kineticjs
reviewed
Sep 13, 2023
| @@ -257,6 +257,18 @@ abstract class ListItem extends ListItemBase { | |||
| @slot() | |||
| deleteButton!: Array<HTMLElement>; | |||
|
|
|||
| /** | |||
| * Defines the icon, displayed in the beginning or end of the list item. | |||
There was a problem hiding this comment.
Minor:
Maybe also add a comment that if a customIcon is set, it will be rendered in place of the standard icon defined in the "icon" property
dobrinyonkov
force-pushed
the
listitem-icon-slot
branch
from
1c67d0e to
ce485bd
Compare
kineticjs
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7481