Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-side-navigation): add accessibleName property #11127

Merged
merged 2 commits into from
Mar 20, 2025
Merged

feat(ui5-side-navigation): add accessibleName property #11127

merged 2 commits into from
Mar 20, 2025

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Mar 18, 2025 •
edited
Loading

fixes: #10928

JIRA: BGSOFUIRODOPI-3434

@TeodorTaushanov TeodorTaushanov requested a review from a team March 18, 2025 13:25
s-todorova
s-todorova reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@s-todorova s-todorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the BLI it states we should consider also adding accessibleNameRef - we have both for other components such as Carousel, ResponsivePopover, Card, etc.

@TeodorTaushanov
Copy link
Member Author

TeodorTaushanov commented Mar 20, 2025 •
edited
Loading

In the BLI it states we should consider also adding accessibleNameRef - we have both for other components such as Carousel, ResponsivePopover, Card, etc.

Here is a bit different, role="navigation" goes with aria-label, but not aria-labelledby. It is the same in the OpenUI5 sap.tnt.SideNavigation.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/navigation_role

@TeodorTaushanov TeodorTaushanov requested a review from a team March 20, 2025 11:16
@TeodorTaushanov TeodorTaushanov merged commit db269e8 into main Mar 20, 2025
12 checks passed
@TeodorTaushanov TeodorTaushanov deleted the side_navigation_acc_name branch March 20, 2025 11:54
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.9.0-rc.2 🎉

The release is available on v2.9.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-todorova s-todorova s-todorova approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SF][A11y][SideNavigation]: accessible-name property is not provided
3 participants
@TeodorTaushanov @ui5-webcomponents-bot @s-todorova