Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-table): remove some unnessary code #11101

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Conversation

aborjinik
Copy link
Contributor

@aborjinik aborjinik commented Mar 14, 2025

_popin attribute now written to the AI action to show the icon smaller in the popin
query decorator is used to access the shadowDom
toggleAttribute Utility is added to set and remove attributes
some redundant code is removed/refactored

@aborjinik aborjinik force-pushed the table-refactoring branch 2 times, most recently from f1c693f to b57eeb6 Compare March 14, 2025 11:23
@aborjinik aborjinik requested a review from DonkeyCo March 14, 2025 11:30
@aborjinik aborjinik requested a review from nnaydenow March 18, 2025 15:37
Copy link
Member

@DonkeyCo DonkeyCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring. @query removes a lot of boiler plate coding which is quite nice

Left one comment, up to you if you want to implement it or not. Just a question of coding style

@aborjinik aborjinik merged commit 9ebf134 into main Mar 19, 2025
12 checks passed
@aborjinik aborjinik deleted the table-refactoring branch March 19, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants