fix(ui5-dynamic-page): correct header snap/pin inconsistency at page top #11098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamenivanov91
requested changes
Mar 20, 2025
| @@ -372,6 +374,17 @@ class DynamicPage extends UI5Element { | |||
| const headerHeight = this.dynamicPageHeader?.getBoundingClientRect().height || 0; | |||
| const currentScrollTop = this.scrollContainer!.scrollTop; | |||
|
|
|||
| if (!this._headerSnapped && this.headerPinned) { | |||
| this.headerPinned = false; | |||
| this.fireDecoratorEvent("pin-button-toggle"); | |||
There was a problem hiding this comment.
are you sure it's correct to fire pin button toggle without actually clicking on the button ?
There was a problem hiding this comment.
I believe firing the event here makes sense. When we programmatically change the pin state (headerPinned = false), it helps notify the UI and any listeners about this state change, similar to when a user clicks the pin button. The event helps ensure the visual state stays in sync with the internal state.
plamenivanov91
approved these changes
Mar 21, 2025
|
🎉 This PR is included in version v2.9.0-rc.2 🎉 The release is available on v2.9.0-rc.2 Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Several issues occurred with the header snap/pin interaction:
Solution:
Fixes: #11088