fix(ui5-tree): noDataText is now properly rendered #11095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem where noDataText wasn't rendered even if there are no tree items in the tree. This is because there was a redundant element as a child of the tree in its tsx template. With this fix, the noDataText is now properly rendered when there are no tree items in the tree. Fixes: SAP#11073
nnaydenow
reviewed
Mar 17, 2025
kgogov
approved these changes
Mar 20, 2025
|
🎉 This PR is included in version v2.9.0-rc.2 🎉 The release is available on v2.9.0-rc.2 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem where noDataText wasn't rendered even if there are no tree items in the tree. This is because there was a an internal element counted as a child of the tree in its tsx template.
With this fix, the noDataText is now properly rendered when there are no tree items in the tree.
Fixes: #11073