fix(ui5-popover): fix popover flickering #10955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandar-mitsev
requested changes
Mar 7, 2025
There was a problem hiding this comment.
- consider using top: -10000px and left: -10000px to hide it before it is positioned
- take a look at Popover._showOutsideViewport() - this code was added some time ago , maybe for similar reason, but it looks like it is never executed
- the opacity:0 is not applied to the Dialog at any point
- add tests
alexandar-mitsev
requested changes
Mar 20, 2025
alexandar-mitsev
approved these changes
Mar 20, 2025
|
🎉 This PR is included in version v2.9.0-rc.2 🎉 The release is available on v2.9.0-rc.2 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10187