Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui5-table): migrate TableSelection wdio tests to cypress #10790

Merged
merged 8 commits into from
Feb 13, 2025
Merged

chore(ui5-table): migrate TableSelection wdio tests to cypress #10790

merged 8 commits into from
Feb 13, 2025

Conversation

nowakdaniel
Copy link
Contributor

Migration of TableSelection.spec.js wdio tests to cypress.

@nowakdaniel nowakdaniel requested a review from DonkeyCo February 6, 2025 14:26
@nowakdaniel nowakdaniel requested a review from aborjinik February 7, 2025 14:26
aborjinik
aborjinik requested changes Feb 10, 2025
View reviewed changes
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
aborjinik
aborjinik approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@aborjinik aborjinik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things... Lets merge ASAP so that spliting selection BLI can benefit from that. If you want to push another PS then please remove the TableSelection.spec.js file

packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
packages/main/cypress/specs/TableSelection.cy.tsx Outdated Show resolved Hide resolved
DonkeyCo
DonkeyCo approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@DonkeyCo DonkeyCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if Cahit has nothing against we can merge it, so that he can benefit from this change as well

@nowakdaniel nowakdaniel merged commit b70b57a into main Feb 13, 2025
12 checks passed
@nowakdaniel nowakdaniel deleted the chore-tablesel-cypress branch February 13, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 left review comments

@aborjinik aborjinik aborjinik approved these changes

@DonkeyCo DonkeyCo DonkeyCo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nowakdaniel @aborjinik @ilhan007 @DonkeyCo