feat(ui5-side-navigation): enable the web component in popover placement #10701
+339
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerganaKremenska
force-pushed
the
sideNavOverlay
branch
from
c1b9554 to
13537de
Compare
GerganaKremenska
changed the title
GerganaKremenska
changed the title
GerganaKremenska
changed the title
Stoev
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Please consider* :
feat(ui5-side-navigation): enable the web component in popover placement
Introduce a new design property to easily enable OverlayMode for ui5-side-navigation, and provide an example of how to implement it.
*(header should be in present imperative tense (https://sap.github.io/ui5-webcomponents/docs/contributing/conventions-and-guidelines/#commit-description))
packages/website/docs/_components_pages/fiori/SideNavigation/SideNavigation.mdx
Outdated
Show resolved
Hide resolved
GerganaKremenska
changed the title
TeodorTaushanov
approved these changes
Mar 18, 2025
|
🎉 This PR is included in version v2.9.0-rc.1 🎉 The release is available on v2.9.0-rc.1 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new design property to easily enable OverlayMode for ui5-side-navigation, and provide an example of how to implement it.
JIRA: BGSOFUIRODOPI-3411