chore(ui5-table): migrate TableNavigation wdio tests to cypress #10620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration of wdio tests (excluding fixed header tests) to the new cypress framework.
nowakdaniel
commented
Jan 22, 2025
ilhan007
reviewed
Jan 30, 2025
DonkeyCo
requested changes
Feb 13, 2025
| .click("left"); | ||
|
|
||
| cy.get("@rows").eq(0).should("be.focused") | ||
|
|
There was a problem hiding this comment.
Formatting is a bit weird here. Why is there a whitespace here?
|
|
||
| cy.get("@rows").eq(0).realPress("F2"); | ||
| cy.get("@row1Input").eq(0).should("be.focused") | ||
|
|
There was a problem hiding this comment.
Again. There are multiple instances in the code, where formatting is just weird. please have a look again
| // otherwise the it would click in the center of the row where an input is | ||
| // resulting in a focus on the input instead of the row | ||
| .click("left"); | ||
| cy.get("@rows").eq(0).should("be.focused") |
There was a problem hiding this comment.
I feel like it would be nice to have a function for this, at it's most of the time the same thing, except for the cy-element switching up.
Maybe a function where you can pass an array of objects containing element and associated action would be neat.
function performActions(actions: Array<{ element: [whatever the cypress element type is], action: string }>)
Usage:
performActions([
{ element: cy.get("@rows").eq(0), action: "{leftarrow}" },
{ element: cy.get("@headerRow"), action: "{uparrow}" },
...
]It would make the tests a bit cleaner I think. Up to you if you want to implement this. Can be also done as a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of
TableNavigation.spec.jswdio tests to cypress. This change does not include the fixed header tests which will be migrated in another PR.