-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid #344
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Internal repo deleted.)
<ComplexType Name="DataFieldMeasures" BaseType="UI.DataFieldGridAbstract"> | ||
<Annotation Term="Core.Description" String="A structured piece of data described by an annotation" /> | ||
<Property Name="Measures" Type="Collection(Edm.PropertyPath)" Nullable="false" /> | ||
</ComplexType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One DataFieldMeasures
already contains several measures, and in addition to that you can have several DataFieldMeasures
s in UI.Grid/Columns
. Why these nested collections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not intented - thanks for the hint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you haven't changed it yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there can be only one datafieldmeasures either in columns or in rows. I'm struggling with the definition of the rows in columns as there either can dimensions and measures there, but measures can either be in the rows or in columns and there are always all together, dimensions can be spread over columns and rows. And of course the measure collection doesn't have a fixed position :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you haven't changed it yet.
Because I had to think about it :-) - I'm not as fast as you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you haven't changed it yet.
Because I had to think about it :-) - I'm not as fast as you.
And if you have an idea how to solve the dilemma, don't hesitate to publish it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there can be only one datafieldmeasures either in columns or in rows
Sounds complicated. Do you have examples, ideally with visuals of the corresponding grids?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will send you (both) an email with a screen shot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there can be only one datafieldmeasures either in columns or in rows. I'm struggling with the definition of the rows in columns as there either can dimensions and measures there, but measures can either be in the rows or in columns and there are always all together, dimensions can be spread over columns and rows. And of course the measure collection doesn't have a fixed position :-).
Let the UI.Grid
have properties Rows
and Columns
, which can each contain
UI.ReferenceFacet
s pointing to aUI.FieldGroupDimensions
withUI.DataField
s with groupable values- a
UI.ReferenceFacet
pointing to aUI.FieldGroupMeasures
withUI.DataField
s with aggregatable values - a
UI.ReferenceFacet
pointing to aUI.CollectionFacet
containingUI.ReferenceFacet
s pointing toAnalytics.StructureElements
and specify the integrity conditions that # 2 must occur exactly once overall and # 3 at most once overall.
See #345
</ComplexType> | ||
<ComplexType Name="DataFieldDimension" BaseType="UI.DataFieldGridAbstract"> | ||
<Annotation Term="Core.Description" String="A structured piece of data described by an annotation" /> | ||
<Property Name="Dimensions" Type="Edm.PropertyPath" Nullable="false" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Property Name="Dimensions" Type="Edm.PropertyPath" Nullable="false" /> | |
<Property Name="Dimension" Type="Edm.PropertyPath" Nullable="false" /> |
Complex type name is singular, and type is also just one property path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I missed that, when I changed the type name from plural to singular
What actually is a "data grid", and why isn't it just another ChartType? odata-vocabularies/vocabularies/UI.xml Lines 793 to 800 in 35c7080
|
Co-authored-by: Ralf Handl <[email protected]>
Co-authored-by: Ralf Handl <[email protected]>
I'm not an expert on that, but a grid has rows and columns which can be flexibly arranged using measures and dimensions (and there is something in addition we left out in the first version, which seems to be called structural properties, which are filter conditions on meaasures - if I got that correctly). So, simply a new chart type wouldn't suffice these requirements. |
A grid cannot show its full power by making OData requests at runtime, it needs InA for that. The purpose of this pull request is only to define a grid through OData annotations (design time), not offer an OData service for the runtime. This could be expressed by having an annotated entity type in the CSDL document, but no entity container. |
first version