Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance annotation for 24:00:00 #234

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

HeikoTheissen
Copy link
Contributor

@HeikoTheissen HeikoTheissen commented Mar 2, 2023

ABAP backends can contain the value 240000 in time fields, and RAP exposes this as "TimeOfDay": "24:00:00". This value is not allowed by the OData specification and not all clients accept this value.

Suggest to expose this instead as

{"ClockOutTime": null,
 "ClockOutMidnight": true}

<Annotations Target="timezone.sample.WorkerTimeSheet/ClockOutTime">
<Annotation Term="Common.IsEndOfDay" Path="ClockOutMidnight" />
</Annotations>

@HeikoTheissen HeikoTheissen requested a review from ralfhandl March 2, 2023 13:29
vocabularies/Common.xml Outdated Show resolved Hide resolved
@HeikoTheissen HeikoTheissen marked this pull request as ready for review March 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants