-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common.DraftXxx: sync with RAP implementation #192
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent may the following sentence should also be changed: "New drafts may also be created by POSTing an empty entity without any properties to the entity set."
"New drafts may also be created by POSTing an entity with property IsActiveEntity=false (default) to the entity set."
In fact also during the creation of a draft root already properties may be set or even have to be set if the "requiredProperties" annotation is used. Therefore the statement with an "empty entity" is not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely typographical review
Co-authored-by: Heiko Theißen <[email protected]>
If we do not deprecate the complete "DraftNode" (which is only used as tag and thus redundant to "DraftActivationVia", we should at least remove or deprecate the ValidationFunction inside that was never used. |
That is already deprecated: odata-vocabularies/vocabularies/Common.xml Lines 1136 to 1146 in c941c4e
@RaizoC Should we deprecate the whole |
Deprecated the term |
I would deprecate it as it only adds redundancy, but we @MarcelWaechter should confirm. |
DraftActivationVia
. @MarcelWaechter: can you confirm the annotation “DraftNode” is NOT used any more in FE V4 (and V2)?