toTimestamp client-side function #105
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
requested changes
Mar 17, 2021
vocabularies/UI.xml
Outdated
Comment on lines
1603
to
1612
| <Function Name="toTimestamp"> | ||
| <Annotation Term="Core.Description" String="Representation of the given point in time as an `Edm.DateTimeOffset` whose [timezone fragment](https://www.w3.org/TR/xmlschema11-2/#nt-tzFrag) is `Z`" /> | ||
| <Parameter Name="Date" Type="Edm.Date"/> | ||
| <Parameter Name="TimeOfDay" Type="Edm.TimeOfDay"/> | ||
| <Parameter Name="Timezone" Type="Edm.String"> | ||
| <Annotation Term="Core.Description" String="Time zone according to the [IANA](https://www.iana.org/time-zones) standard" /> | ||
| <Annotation Term="Core.LongDescription" String="If absent, the time zone of the UI (Fiori Launchpad) is implied" /> | ||
| </Parameter> | ||
| <ReturnType Type="Edm.DateTimeOffset"/> | ||
| </Function> |
There was a problem hiding this comment.
This defines a server-side function.
We should discuss in the OData TC whether this is also the way to go for defining client-side functions, and how to mark these functions as "client-side".
Could you please open a TC jira issue?
There was a problem hiding this comment.
…it into toTimestamp
into toTimestamp Conflicts: vocabularies/UI.md
Conflicts: vocabularies/Common.json vocabularies/Common.md vocabularies/Common.xml vocabularies/UI.json vocabularies/UI.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites:
The client can delegate execution of the function to the server with
or
The latter, however, makes sense only if the OData server knows the annotation definition. But then it could as well expose a Timestamp property. The whole point of annotations is that they can be contributed by a party different from the OData server. However, that party might serve as a proxy between client and server that converts the second GET request into the first.