Expanded linting #146
Merged
Expanded linting #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_bs_icon` is only called in `icon`, so there is no reason for it to be a separate function. Additionally, by moving it to `icon`, we can ensure that only whitelisted icon names are used, reducing the chance of actual string injection attacks.
By changing `select` to `extend-select`, we keep the default Ruff lints enabled. Additionally, there are some more lints that we care about that have both been enabled and fixed in this commit.
Restioson
force-pushed
the
lint/expanded-linting
branch
from
e925030
to
3acf4d0
Compare
friedelwolff
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing
selecttoextend-select, we keep the default Ruff lints enabled. Additionally, there are some more lints that we care about that have both been enabled and fixed in this commit.