test: run Selenium tests on more browsers/JS configurations #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares the ground for Selenium tests to be run in a Matrix strategy with multiple different configurations (with JS, without JS, Firefox, Chrome, etc).
Restioson
force-pushed
the
test/multiple-browser-selenium
branch
2 times, most recently
from
c9f71f3
to
df38598
Compare
Restioson
requested review from
friedelwolff and
jrb-s2c-github
as code owners
Restioson
force-pushed
the
test/multiple-browser-selenium
branch
from
df38598
to
06f7020
Compare
friedelwolff
reviewed
Nov 6, 2024
friedelwolff
requested changes
Nov 6, 2024
I'm not quite sure what you mean? The commit message I have is "this prepares the ground for Selenium tests to be run in a Matrix strategy with multiple different configurations (with JS, without JS, Firefox, Chrome, etc)."
I noticed this and updated it locally a while back - seems like it got overwritten by something in the meanwhile though. I'll make sure to update it when squashing up the PR 👍
I will create it now! |
friedelwolff
approved these changes
Nov 7, 2024
By passing the browser type and whether JS is enabled via environment variables, we can run the Selenium frontend tests on all combinations of targetted browsers and JS/no-JS in the CI pipeline. For now, we are not targetting Safari for this, as the GitHub Actions MacOS workers don't suppose `services`, which we use to run the postgres database. This will be left for a follow-up (see issue #145).
Restioson
force-pushed
the
test/multiple-browser-selenium
branch
from
dcaec1c
to
ce0bdf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing the browser type and whether JS is enabled via environment variables, we can run the Selenium front-end tests on all combinations of targeted browsers and JS/no-JS in the CI pipeline. The way it works from the CI perspective is by using a Matrix strategy which is then substituted into an environment variable when calling
manage.py test --tag=seleniumFixes #143. However, #145 is not addressed, as this PR doesn't tackle Safari. This is because GitHub Actions MacOS workers don't support
services, which we use to run the postgres database. This can be left for a follow-up PR.