-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge existing work into main branch #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create docker push action for main branch
- added github actions testing - updated enviroment variables in settings - added tests for logging files - updated setting to check for testing
added basic logging and updated environment variables
Add dark mode css file, and add to admin template
changed colour of breadcrumbs
- updated institution fixtures - updated project fixtures - updated institution templetes
added pillow and updated image inputs models
Accessibility colour changes
Feature: front page copy
Alter styling for logos
Search button to direct to search page
…oduction Allowing for deployment to prod
- updated admin test - updated docker files with libmagic1 - updated Readme file
remove handlers in urls and error views
Fix error pages views
added search and filters to document files in admin
added magic to check mime_type
Add initial settings for internationalisation add language settings, add .mo files to git ignore, and add makefile commands
…ings Add initial settings for internationalisation
Add new efficient way to calculate completion weighting, add to template and unit test
One reference to "PDF" is removed to make message useful if other filetypes are supported in future.
This fixes the problem with a partial page showing on browser restore, or for example with Firefox plugin "Auto Tab Discard" if a tab is restored. It will also be required if "real" caching is implemented.
Admin refinements
Ensure HTML pages vary on HX-Request
Simpler API, improved tests, including some cleanup. Admin form only parses the PDF if it passes other validation. Mass import is called with parameter, and only reads files instead of moving around and pretty printing.
Rework text extraction
This affords the developers the same vocabulary as the users. See commit ba1b6cc.
Rename documentfile to document
We also provide the defaults as they are in Django, instead of implicitly setting them to None.
Obtain more email settings from environment
Format ADMINS setting as Django expects
Allow easy form styling using bootstrap. This way we can render forms with {{ form }} instead of having to manually handle each field verbosely.
Entirely rework the accounts front-end to simplify things and align better with built-in Django: - Use Bootstrap infrastructure to render forms plainly in templates (see previous commit). - Rename forms and views to correspond to the builtin ones, but ensure that the builtin ones can't accidentally be imported. - Use a base template for all account-related pages to ensure consistency. - Reuse the exact wording in Django templates in more places to be able to reuse Django translations seamlessly. - Avoid duplicate URLs that can be confusing if you hit the wrong one.
Styling and indenting in the footer is slightly reworked, as the logout view has to be invoked with a POST. `hx-disable` is added in the cases where a full-page reload is required. With the admin link removed, the navbar now has more space for label expansion in other languages.
Rework accounts
Although not invalid, it makes it easier to make a mistake with unquoted attributes before, and is plainly not needed in HTML5.
Block-level elements are not allowed in a p tag.
HTML fixes
Only two blocks. Apart from a simpler structure, the idea is also to not start the page with links that lead the user off the site.
Lwimilinks branding
Actual changes to logo files left out in commit b8b8b8c.
+LwimiLinks logo (x2)
jrb-s2c-github
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.