Skip to content

Commit

Permalink
fix(ci): set persist-credentials to false
Browse files Browse the repository at this point in the history
This was a linting failure from
[zizmor](https://blog.yossarian.net/2024/10/27/Now-you-can-have-beautiful-clean-workflows).
See actions/checkout#485 for more info on why this is
a potential security issue.
  • Loading branch information
Restioson committed Nov 5, 2024
1 parent c18592b commit e07ccb8
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to SADiLaR Container Registry
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Login to SADiLaR Container Registry
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: 3.12
Expand Down Expand Up @@ -80,6 +82,8 @@ jobs:
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: 3.12
Expand Down Expand Up @@ -126,6 +130,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false
- name: Get all commits on current main
run: git fetch origin main
- name: Log all commits we will analyse
Expand Down

0 comments on commit e07ccb8

Please sign in to comment.