fix: Device names on Android #959
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
feat/android-device-name
branch
from
8beb627 to
dfed2b5
Compare
|
The CI failure for the WASM build seems unrelated to me. |
|
Hi, I've just merged #961. Could you confirm if the issue persists in the new Android backend and if yes, adjust the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Device::name()onoboehost (Android) only contains theoboe::AudioDeviceInfo::product_namestring. This is, however, identical for all internal audio devices.This PR changes this to add the
AudioDeviceTypeand, if present theaddress, which then gives an actually useful list of audio devices.List of device names before:
["Pixel 8", "Pixel 8", "Pixel 8", "Pixel 8", ...]List of devices names after
["Pixel 8:BuiltinEarpiece", "Pixel 8:BuiltinSpeaker", "Pixel 8:BuiltinMic:bottom", "Pixel 8:BuiltinMic:back", ...]