Oboe: use Unprocessed preset for input streams #888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm currently using cpal in an Android application and everything seems to work well.
However, I've noticed that this crate lacks support for Oboe's InputPresets, which is quite an important thing for certain projects. At the moment the default preset is
VoiceRecognition.It would be great if one could choose the best preset when building the stream, but that would require either to change the signature of the function (making not adhere anymore to the relative trait), or to set this preset within a static config variable, or something similar.
In the meantime I think it would make sense to use
Unprocessedpreset, which does not apply any effect, making the user able to obtain full control over the stream.