Implement custom blend modes #1439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hominilupoid
commented
Oct 11, 2024
| @@ -9,6 +9,8 @@ when upgrading from a version of rust-sdl2 to another. | |||
|
|
|||
| [PR #1407](https://github.com/Rust-SDL2/rust-sdl2/pull/1407) Add new use_ios_framework for linking to SDL2.framework on iOS | |||
|
|
|||
| [PR #1439](https://github.com/Rust-SDL2/rust-sdl2/pull/1439) **BREAKING CHANGE** Implement custom blend modes | |||
There was a problem hiding this comment.
Should this be marked Maybe breaking change by the same criteria as #1156 in v0.35.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the possibility to compose custom blend modes through a builder type. Additionally removes some transmutes and unnecessary
try_froms from conversions fromu32toBlendModeand cleans out some bindgen-generated related code insdl2-sys.enum BlendModenow has one additional variant for representing custom blend modes, which technically constitutes a breaking change, even though likely quite a marginal one in real-world use.Addresses issue #878.