Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump @storybook/addon-webpack5-compiler-babel from 3.0.3 to 3.0.5 #35439

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

chore(deps): bump @storybook/addon-webpack5-compiler-babel from 3.0.3 to 3.0.5 #35439

wants to merge 3 commits into from
+43 −43

Conversation

cardoso
Copy link
Contributor

@cardoso cardoso commented Mar 8, 2025

Proposed changes (including videos or screenshots)

Fix running storybook locally. It's broken due to this dependency version not being compatible with Node v22.

Full output below.

SB_CORE-SERVER_0002 (CriticalPresetLoadError): Storybook failed to load the following preset: ./.storybook/main.ts.

Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

If you believe this is a bug, please open an issue on Github.

SB_CORE-SERVER_0002 (CriticalPresetLoadError): Storybook failed to load the following preset: ./node_modules/@storybook/addon-webpack5-compiler-babel/preset.js.

Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

If you believe this is a bug, please open an issue on Github.

ReferenceError: module is not defined
at file://./node_modules/@storybook/addon-webpack5-compiler-babel/preset.js:1:1
at ModuleJobSync.runSync (node:internal/modules/esm/module_job:395:35)
at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:329:47)
at loadESMFromCJS (node:internal/modules/cjs/loader:1411:24)
at Module._compile (node:internal/modules/cjs/loader:1544:5)
at node:internal/modules/cjs/loader:1668:16
at Object.newLoader (./node_modules/esbuild-register/dist/node.js:2262:9)
at extensions..js (./node_modules/esbuild-register/dist/node.js:4833:24)
at Module.load (node:internal/modules/cjs/loader:1313:32)
at Function._load (node:internal/modules/cjs/loader:1123:12)

More info:

at loadPreset (./node_modules/@storybook/core/dist/common/index.cjs:16512:13)

More info:

at loadPreset (./node_modules/@storybook/core/dist/common/index.cjs:16512:13)
at async Promise.all (index 1)
at async loadPresets (./node_modules/@storybook/core/dist/common/index.cjs:16522:55)
at async getPresets (./node_modules/@storybook/core/dist/common/index.cjs:16555:11)
at async buildDevStandalone (./node_modules/@storybook/core/dist/core-server/index.cjs:37138:11)
at async withTelemetry (./node_modules/@storybook/core/dist/core-server/index.cjs:35750:12)
at async dev (./node_modules/@storybook/core/dist/cli/bin/index.cjs:2591:3)
at async s.<anonymous> (./node_modules/@storybook/core/dist/cli/bin/index.cjs:2643:74)

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

WARN Failed to load preset: {"type":"presets","name":"~/RocketChat/Rocket.Chat/apps/meteor/node_modules/@storybook/addon-webpack5-compiler-babel/preset.js"} on level 1
Error [ERR_REQUIRE_CYCLE_MODULE]: Cannot require() ES Module ./node_modules/@storybook/addon-webpack5-compiler-babel/preset.js in a cycle. (from ./node_modules/@storybook/core/dist/common/index.cjs)
at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:315:15)
at loadESMFromCJS (node:internal/modules/cjs/loader:1411:24)
at Module._compile (node:internal/modules/cjs/loader:1544:5)
at node:internal/modules/cjs/loader:1668:16
at Object.newLoader (./node_modules/esbuild-register/dist/node.js:2262:9)
at extensions..js (./node_modules/esbuild-register/dist/node.js:4833:24)
at Module.load (node:internal/modules/cjs/loader:1313:32)
at Function._load (node:internal/modules/cjs/loader:1123:12)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)

Most relevant part:

Error [ERR_REQUIRE_CYCLE_MODULE]: Cannot require() ES Module ./node_modules/@storybook/addon-webpack5-compiler-babel/preset.js in a cycle.

Issue(s)

Steps to test or reproduce

Make sure you're using the currently required node version:

% nvm install 22.13.1
v22.13.1 is already installed.
Now using node v22.13.1 (npm v10.9.2)

Then run from the root folder:

% yarn
% yarn build
% yarn storybook

Further comments

Changelogs for this dependency:

https://github.com/storybookjs/addon-webpack5-compiler-babel/releases

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 8, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@julio-rocketchat julio-rocketchat added the stat: QA assured Means it has been tested and approved by a company insider label Mar 9, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0e8b355

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cardoso
Copy link
Contributor Author

cardoso commented Mar 9, 2025

@julio-rocketchat I just noticed the dependency is version ^3.0.3 in other 9 packages too.

Rocket.Chat/ee/packages/pdf-worker/package.json

Line 33 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

8 more...

Rocket.Chat/packages/fuselage-ui-kit/package.json

Line 69 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/gazzodown/package.json

Line 46 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/livechat/package.json

Line 39 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-client/package.json

Line 37 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-composer/package.json

Line 30 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-video-conf/package.json

Line 39 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-voip/package.json

Line 45 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/web-ui-registration/package.json

Line 33 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

It all resolves to 3.0.5 anyway, but I should probably update those as well.

"@storybook/addon-webpack5-compiler-babel@npm:^3.0.3, @storybook/addon-webpack5-compiler-babel@npm:^3.0.5":
  version: 3.0.5
  resolution: "@storybook/addon-webpack5-compiler-babel@npm:3.0.5"
  dependencies:
    "@babel/core": "npm:^7.26.0"
    babel-loader: "npm:^9.2.1"
  checksum: 10/32249b0dbf704f0eb79bd3e0e1fa05b5e7a684b03d350338823afafcb306ff2b4e7de9bac4fd1436038290e544e95a4ac140455ef3af7ae17aa965d1b6dc32e7
  languageName: node
  linkType: hard

@cardoso cardoso requested review from a team as code owners March 9, 2025 16:08
@julio-rocketchat
Copy link
Member

julio-rocketchat commented Mar 9, 2025 •
edited
Loading

@julio-rocketchat I just noticed the dependency is version ^3.0.3 in other 9 packages too.

Rocket.Chat/ee/packages/pdf-worker/package.json

Line 33 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

8 more...

Rocket.Chat/packages/fuselage-ui-kit/package.json

Line 69 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/gazzodown/package.json

Line 46 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/livechat/package.json

Line 39 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-client/package.json

Line 37 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-composer/package.json

Line 30 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-video-conf/package.json

Line 39 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/ui-voip/package.json

Line 45 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

Rocket.Chat/packages/web-ui-registration/package.json

Line 33 in f925052

"@storybook/addon-webpack5-compiler-babel": "^3.0.3",

It all resolves to 3.0.5 anyway, but I should probably update those as well.

"@storybook/addon-webpack5-compiler-babel@npm:^3.0.3, @storybook/addon-webpack5-compiler-babel@npm:^3.0.5":
  version: 3.0.5
  resolution: "@storybook/addon-webpack5-compiler-babel@npm:3.0.5"
  dependencies:
    "@babel/core": "npm:^7.26.0"
    babel-loader: "npm:^9.2.1"
  checksum: 10/32249b0dbf704f0eb79bd3e0e1fa05b5e7a684b03d350338823afafcb306ff2b4e7de9bac4fd1436038290e544e95a4ac140455ef3af7ae17aa965d1b6dc32e7
  languageName: node
  linkType: hard

Would you be able to update them as well? And then I can reapprove the PR once tests have passed.

@julio-rocketchat julio-rocketchat self-requested a review March 9, 2025 16:08
@julio-rocketchat julio-rocketchat removed the stat: QA assured Means it has been tested and approved by a company insider label Mar 9, 2025
cardoso
cardoso commented Mar 9, 2025
View reviewed changes
Copy link
Contributor Author

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work better after I updated all packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julio-rocketchat julio-rocketchat Awaiting requested review from julio-rocketchat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cardoso @julio-rocketchat