Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: videoconf ringer not working after a temporary disconnection #35431

Open
wants to merge 1 commit into
base: release-7.3.4
Choose a base branch
from

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Mar 7, 2025

Backport of #35330

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner March 7, 2025 20:20
@dionisio-bot dionisio-bot bot requested a review from pierre-lehnen-rc March 7, 2025 20:20
@dionisio-bot dionisio-bot bot added the backport label Mar 7, 2025
Copy link
Contributor Author

dionisio-bot bot commented Mar 7, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35431/

Built to branch gh-pages at 2025-03-07 20:33 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (aeab9d3) to head (69e01c7).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.3.4   #35431      +/-   ##
=================================================
- Coverage          59.16%   59.16%   -0.01%     
=================================================
  Files               2821     2821              
  Lines              68112    68109       -3     
  Branches           15145    15144       -1     
=================================================
- Hits               40297    40294       -3     
  Misses             24981    24981              
  Partials            2834     2834              
Flag Coverage Δ
unit 74.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants