Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VoIP calls one-way audio issues #35420

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

For now this is just a PoC fix: it solves the problem, but it's not the best solution.

Issue(s)

Steps to test or reproduce

Further comments

To prevent react from destroying the audio element that is playing a call's audio, a workaround was made to pass this element as reference to the voip client, but in some situations the element was not passed at all and the voipclient had nothing to play the audio on.
For now I'm just passing this reference to the client after a successful SIP registration - this ensures the element will always be there. For safeguard I'm also passing it when a call is fully established.

The old code was already passing it on when the call is established, but only for the user who's receiving the call. This is why the problem happened a lot more often for the caller than the callee. What's even more strange, is that PR #33404 inverted this behavior. It used to be only the caller, now it's only the callee.

Going even further, I noticed that the omnichannel team has run into the exact same problem years ago with their own voip solution. And they left a long comment in the code talking about it. The solution they came up with is also not that great, so we might go ahead and fix it properly in both places now.

Copy link
Contributor

dionisio-bot bot commented Mar 7, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: 6f97a12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35420/

Built to branch gh-pages at 2025-03-07 03:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (bc23e6f) to head (6f97a12).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35420   +/-   ##
========================================
  Coverage    59.46%   59.46%           
========================================
  Files         2830     2830           
  Lines        68582    68582           
  Branches     15178    15178           
========================================
  Hits         40781    40781           
  Misses       25132    25132           
  Partials      2669     2669           
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant