Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow omnichannel agents to join closed rooms #35414

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Mar 6, 2025

Proposed changes (including videos or screenshots)

Fixes issue of agents trying to preview a closed livechat room without preview-c-room permission d

Issue(s)

SUP-748

Steps to test or reproduce

  1. add user as an agent
  2. start livechat conversation
  3. close conversation
  4. go to contact center
  5. click on the closed chat
  6. click on open room on the sidebar
  7. click on join channel

the join channel screen should not appear for livechat rooms, as these cannot be joined once closed and they have their own permissions for visibility

Further comments

Copy link
Contributor

dionisio-bot bot commented Mar 6, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: bbfd197

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (279dc55) to head (bbfd197).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35414   +/-   ##
========================================
  Coverage    59.46%   59.46%           
========================================
  Files         2830     2830           
  Lines        68582    68582           
  Branches     15178    15178           
========================================
  Hits         40781    40781           
  Misses       25132    25132           
  Partials      2669     2669           
Flag Coverage Δ
unit 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MartinSchoeler MartinSchoeler changed the title fix: don't allow agents to preview closed room if they don't have permission fix: don't allow omnichannel agents to join closed rooms Mar 6, 2025
@MartinSchoeler MartinSchoeler marked this pull request as ready for review March 6, 2025 19:24
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner March 6, 2025 19:24
@aleksandernsilva aleksandernsilva added this to the 7.5.0 milestone Mar 6, 2025
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35414/

Built to branch gh-pages at 2025-03-07 13:25 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants