-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't allow omnichannel agents to join closed rooms #35414
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: bbfd197 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35414 +/- ##
========================================
Coverage 59.46% 59.46%
========================================
Files 2830 2830
Lines 68582 68582
Branches 15178 15178
========================================
Hits 40781 40781
Misses 25132 25132
Partials 2669 2669
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
|
Proposed changes (including videos or screenshots)
Fixes issue of agents trying to preview a closed livechat room without
preview-c-room
permission dIssue(s)
SUP-748
Steps to test or reproduce
the
join channel
screen should not appear for livechat rooms, as these cannot be joined once closed and they have their own permissions for visibilityFurther comments