Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Close open channel when 'Hide' is clicked #35413

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Ansh-dS
Copy link

@Ansh-dS Ansh-dS commented Mar 6, 2025

Proposed changes (including videos or screenshots)

Screen.Recording.2025-03-06.164755.mp4

Issue(s)

#35412

Steps to Reproduce:

  1. Open a team, channel, or direct message from the left pane.
  2. Click on the three dots (more options) of the selected item (ensure the selected item is open on the right side).
  3. Click on "Hide."
  4. Observe whether the right-side panel also closes.

@Ansh-dS Ansh-dS requested a review from a team as a code owner March 6, 2025 12:56
Copy link
Contributor

dionisio-bot bot commented Mar 6, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 5a83402

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ansh-dS seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants