Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix issue #35402: missing comma in package.json.ejs.t #35404

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

omaraymanatia
Copy link

@omaraymanatia omaraymanatia commented Mar 5, 2025

Title

fix: Fix issue #35402 - missing comma in package.json.ejs.t


Proposed changes

The _templates/package/new/package.json.ejs.t file was missing a comma between "dev" and "build-preview", causing a JSON syntax error.
This issue was breaking package installation and script execution.

Fix:

  • Added the missing comma to ensure proper JSON syntax.
  • The file now works as expected.

Issue(s)

Fixes #35402


Steps to test or reproduce

  1. Before the fix, running npm install would result in a JSON syntax error.
  2. After the fix, npm install and script execution function correctly.

Further comments

This was a minor syntax issue but had a significant impact on package management. The fix ensures package.json.ejs.t remains valid and functional.

@omaraymanatia omaraymanatia requested a review from a team as a code owner March 5, 2025 21:24
Copy link
Contributor

dionisio-bot bot commented Mar 5, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: 6f598fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@omaraymanatia omaraymanatia changed the title Fix issue #35402: missing comma in package.json.ejs.t fix: Fix issue #35402: missing comma in package.json.ejs.t Mar 5, 2025
@NawazTalha
Copy link

Hello @omaraymanatia this issue was already fixed by me . You can work on another issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: Missing Comma in package.json Scripts Section (Syntax Error)
4 participants