Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation-v2): can not assign to readonly property #name #35397

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

debdutdeb
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Mar 4, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: 4e8ee30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@debdutdeb debdutdeb force-pushed the federation-v2/passing-readonly-object branch from 5dc3828 to b238ac0 Compare March 4, 2025 18:12
@debdutdeb
Copy link
Member Author

Don't click on "update branch" pls

@debdutdeb debdutdeb changed the base branch from develop to version-7.3.0 March 4, 2025 18:15
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (bc23e6f) to head (4e8ee30).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35397   +/-   ##
========================================
  Coverage    59.46%   59.46%           
========================================
  Files         2830     2830           
  Lines        68582    68583    +1     
  Branches     15178    15178           
========================================
+ Hits         40781    40782    +1     
  Misses       25132    25132           
  Partials      2669     2669           
Flag Coverage Δ
unit 75.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@debdutdeb debdutdeb changed the base branch from version-7.3.0 to develop March 7, 2025 07:37
Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35397/

Built to branch gh-pages at 2025-03-07 07:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant