Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Save button remains in loading state after saving app settings #35394

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
+172 −17
Open

fix: Save button remains in loading state after saving app settings #35394

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4c41d8d
fix: Save button remains in loading state after saving app settings
sushen123 Mar 4, 2025
503b6f7
Add changeset for save button loading state fix
sushen123 Mar 4, 2025
ff32d91
Update changeset for save button
sushen123 Mar 4, 2025
9be6db7
fix: Hide footer after saving app settings
sushen123 Mar 5, 2025
b46f1d8
Add Unit test for AppDetailsPage.tsx
sushen123 Mar 7, 2025
2a8368e
Merge branch 'develop' into fix/save-button-loading-state
sushen123 Mar 7, 2025
478f114
tests
abhinavkrin Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-eyes-clean.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes the save button loading state in the app settings page. The button now exits the loading state after settings are successfully saved. This resolves an issue where the button remained in a loading state indefinitely due to incorrect dependency on the `isSubmitted` state from `react-hook-form`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fixes the save button loading state in the app settings page. The button now exits the loading state after settings are successfully saved. This resolves an issue where the button remained in a loading state indefinitely due to incorrect dependency on the `isSubmitted` state from `react-hook-form`.
Fixes the save button loading state in app settings, ensuring it resets properly after saving.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok , I’ve made the changes

4 changes: 2 additions & 2 deletions apps/meteor/client/views/marketplace/AppDetailsPage/AppDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const AppDetailsPage = ({ id }: AppDetailsPageProps): ReactElement => {
const {
handleSubmit,
reset,
formState: { isDirty, isSubmitting, isSubmitted },
formState: { isDirty, isSubmitting },
} = methods;

return (
Expand Down Expand Up @@ -125,7 +125,7 @@ const AppDetailsPage = ({ id }: AppDetailsPageProps): ReactElement => {
<ButtonGroup>
<Button onClick={() => reset()}>{t('Cancel')}</Button>
{installed && isAdminUser && (
<Button primary loading={isSubmitting || isSubmitted} onClick={handleSubmit(saveAppSettings)}>
<Button primary loading={isSubmitting} onClick={handleSubmit(saveAppSettings)}>
{t('Save_changes')}
</Button>
)}
Expand Down
Loading