Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropdown not closing when clicking outside and obstructing 'Create' button in Direct Message modal (#35375) #35376

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+177 −100
Open

fix: Dropdown not closing when clicking outside and obstructing 'Create' button in Direct Message modal (#35375) #35376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
843d761
Fix dropdown not closing when clicking outside and obstructing 'Creat…
schourasia750 Mar 1, 2025
44bb004
Merge branch 'develop' into fix-dropdown-issue-35375
schourasia750 Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
277 changes: 177 additions & 100 deletions apps/meteor/client/components/UserAutoCompleteMultiple/UserAutoCompleteMultipleFederated.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,122 +5,199 @@ import { UserAvatar } from '@rocket.chat/ui-avatar';
import { useEndpoint } from '@rocket.chat/ui-contexts';
import { keepPreviousData, useQuery } from '@tanstack/react-query';
import type { ReactElement, AllHTMLAttributes } from 'react';
import { memo, useState, useCallback, useMemo } from 'react';
import React, { memo, useState, useCallback, useMemo, useRef, useEffect } from 'react';

import AutocompleteOptions, { OptionsContext } from './UserAutoCompleteMultipleOptions';

type UserAutoCompleteMultipleFederatedProps = {
onChange: (value: Array<string>) => void;
value: Array<string>;
placeholder?: string;
onChange: (value: Array<string>) => void;
value: Array<string>;
placeholder?: string;
} & Omit<AllHTMLAttributes<HTMLElement>, 'is' | 'onChange'>;

type UserAutoCompleteOptionType = {
name: string;
username: string;
_federated?: boolean;
name: string;
username: string;
_federated?: boolean;
};

type UserAutoCompleteOptions = {
[k: string]: UserAutoCompleteOptionType;
[k: string]: UserAutoCompleteOptionType;
};

const matrixRegex = new RegExp('@(.*:.*)');

const UserAutoCompleteMultipleFederated = ({
onChange,
value,
placeholder,
...props
onChange,
value,
placeholder,
...props
}: UserAutoCompleteMultipleFederatedProps): ReactElement => {
const [filter, setFilter] = useState('');
const [selectedCache, setSelectedCache] = useState<UserAutoCompleteOptions>({});

const debouncedFilter = useDebouncedValue(filter, 500);
const getUsers = useEndpoint('GET', '/v1/users.autocomplete');

const { data } = useQuery({
queryKey: ['users.autocomplete', debouncedFilter],

queryFn: async () => {
const users = await getUsers({ selector: JSON.stringify({ term: debouncedFilter }) });
const options = users.items.map((item): [string, UserAutoCompleteOptionType] => [item.username, item]);

// Add extra option if filter text matches `username:server`
// Used to add federated users that do not exist yet
if (matrixRegex.test(debouncedFilter)) {
options.unshift([debouncedFilter, { name: debouncedFilter, username: debouncedFilter, _federated: true }]);
}

return options;
},

placeholderData: keepPreviousData,
});

const options = useMemo(() => data || [], [data]);

const onAddUser = useCallback(
(username: string): void => {
const user = options.find(([val]) => val === username)?.[1];
if (!user) {
throw new Error('UserAutoCompleteMultiple - onAddSelected - failed to cache option');
}
setSelectedCache((selectedCache) => ({ ...selectedCache, [username]: user }));
},
[setSelectedCache, options],
);

const onRemoveUser = useCallback(
(username: string): void =>
setSelectedCache((selectedCache) => {
const users = { ...selectedCache };
delete users[username];
return users;
}),
[setSelectedCache],
);

const handleOnChange = useCallback(
(usernames: string[]) => {
onChange(usernames);
const newAddedUsername = usernames.filter((username) => !value.includes(username))[0];
const removedUsername = value.filter((username) => !usernames.includes(username))[0];
setFilter('');
newAddedUsername && onAddUser(newAddedUsername);
removedUsername && onRemoveUser(removedUsername);
},
[onChange, setFilter, onAddUser, onRemoveUser, value],
);

return (
<OptionsContext.Provider value={{ options: options as unknown as OptionType[] }}>
<MultiSelectFiltered
{...props}
data-qa-type='user-auto-complete-input'
placeholder={placeholder}
value={value}
onChange={handleOnChange}
filter={filter}
setFilter={setFilter}
renderSelected={({ value, onMouseDown }: { value: string; onMouseDown: () => void }) => {
const currentCachedOption = selectedCache[value] || {};

return (
<Chip key={value} height='x20' onMouseDown={onMouseDown} mie={4} mb={2}>
{currentCachedOption._federated ? <Icon size='x20' name='globe' /> : <UserAvatar size='x20' username={value} />}
<Box is='span' margin='none' mis={4}>
{currentCachedOption.name || currentCachedOption.username || value}
</Box>
</Chip>
);
}}
renderOptions={AutocompleteOptions}
options={options.concat(Object.entries(selectedCache)).map(([, item]) => [item.username, item.name || item.username])}
data-qa='create-channel-users-autocomplete'
/>
</OptionsContext.Provider>
);
const [filter, setFilter] = useState('');
const [selectedCache, setSelectedCache] = useState<UserAutoCompleteOptions>({});
const [dropUp, setDropUp] = useState(false);
const dropdownRef = useRef<HTMLDivElement>(null);

const debouncedFilter = useDebouncedValue(filter, 500);
const getUsers = useEndpoint('GET', '/v1/users.autocomplete');

const { data } = useQuery({
queryKey: ['users.autocomplete', debouncedFilter],

queryFn: async () => {
const users = await getUsers({ selector: JSON.stringify({ term: debouncedFilter }) });
const options = users.items.map((item): [string, UserAutoCompleteOptionType] => [item.username, item]);

// Add extra option if filter text matches `username:server`
// Used to add federated users that do not exist yet
if (matrixRegex.test(debouncedFilter)) {
options.unshift([debouncedFilter, { name: debouncedFilter, username: debouncedFilter, _federated: true }]);
}

return options;
},

placeholderData: keepPreviousData,
});

const options = useMemo(() => data || [], [data]);

const onAddUser = useCallback(
(username: string): void => {
const user = options.find(([val]) => val === username)?.[1];
if (!user) {
throw new Error('UserAutoCompleteMultiple - onAddSelected - failed to cache option');
}
setSelectedCache((selectedCache) => ({ ...selectedCache, [username]: user }));
},
[setSelectedCache, options],
);

const onRemoveUser = useCallback(
(username: string): void =>
setSelectedCache((selectedCache) => {
const users = { ...selectedCache };
delete users[username];
return users;
}),
[setSelectedCache],
);

const handleOnChange = useCallback(
(usernames: string[]) => {
onChange(usernames);
const newAddedUsername = usernames.find((username) => !value.includes(username));
const removedUsername = value.find((username) => !usernames.includes(username));
setFilter('');
newAddedUsername && onAddUser(newAddedUsername);
removedUsername && onRemoveUser(removedUsername);
},
[onChange, setFilter, onAddUser, onRemoveUser, value],
);

const toggleDropDirection = () => {
setDropUp((prev) => !prev);
};

// Function to adjust dropdown position
const adjustDropdownPosition = () => {
if (dropdownRef.current) {
const rect = dropdownRef.current.getBoundingClientRect();
const dropdownHeight = 200; // Approximate height of the dropdown
const spaceBelow = window.innerHeight - rect.bottom;

if (!dropUp && spaceBelow < dropdownHeight) {
setDropUp(true);
}
}
};

// Click-outside detection
useEffect(() => {
const handleClickOutside = (event: MouseEvent) => {
if (dropdownRef.current && !dropdownRef.current.contains(event.target as Node)) {
setFilter(''); // Close the dropdown by clearing the filter
}
};

document.addEventListener('mousedown', handleClickOutside);
return () => {
document.removeEventListener('mousedown', handleClickOutside);
};
}, []);

// Adjust dropdown position
useEffect(() => {
adjustDropdownPosition();

if (filter) {
window.addEventListener('resize', adjustDropdownPosition);
} else {
window.removeEventListener('resize', adjustDropdownPosition);
}

return () => {
window.removeEventListener('resize', adjustDropdownPosition);
};
}, [filter, dropUp]);

return (
<div ref={dropdownRef} style={{ width: '100%' }}>
<style>
{`
.dropup .rcx-options {
top: auto;
bottom: 100%;
}
`}
</style>
<OptionsContext.Provider value={{ options: options as unknown as OptionType[] }}>
<MultiSelectFiltered
{...props}
style={{ width: '100%' }}
data-qa-type='user-auto-complete-input'
placeholder={placeholder}
value={value}
onChange={handleOnChange}
filter={filter}
setFilter={setFilter}
className={dropUp ? 'dropup' : ''}
renderSelected={({ value, onMouseDown }: { value: string; onMouseDown: () => void }) => {
const currentCachedOption = selectedCache[value] || {};

return (
<Chip key={value} height='x20' onMouseDown={onMouseDown} mie={4} mb={2}>
{currentCachedOption._federated ? (
<Icon size='x20' name='globe' />
) : (
<UserAvatar size='x20' username={value} />
)}
<Box is='span' margin='none' mis={4}>
{currentCachedOption.name || currentCachedOption.username || value}
</Box>
</Chip>
);
}}
renderOptions={AutocompleteOptions}
options={options.concat(Object.entries(selectedCache)).map(([, item]) => [
item.username,
item.name || item.username,
])}
data-qa='create-channel-users-autocomplete'
addon={
<Icon
name={dropUp ? 'chevron-up' : 'chevron-down'}
size='x20'
onClick={(e) => {
e.stopPropagation();
toggleDropDirection();
}}
/>
}
/>
</OptionsContext.Provider>
</div>
);
};

export default memo(UserAutoCompleteMultipleFederated);