Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'slide' drawer type #5749

Merged
merged 2 commits into from
Jun 24, 2024
Merged

feat: 'slide' drawer type #5749

merged 2 commits into from
Jun 24, 2024

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Jun 17, 2024

Proposed changes

Small change for drawer behavior, but an important fix for accessibility.

Issue(s)

How to test or reproduce

Before

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-17.at.17.02.33.mp4
Screenshot 2024-06-17 at 5 01 55 PM

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-17.at.17.02.53.mp4
Screenshot 2024-06-17 at 5 01 16 PM

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-588

@diegolmello diegolmello marked this pull request as ready for review June 17, 2024 20:00
@diegolmello diegolmello changed the title feat: Slide drawer type feat: 'slide' drawer type Jun 17, 2024
@diegolmello diegolmello merged commit 20e7c79 into develop Jun 24, 2024
3 of 5 checks passed
@diegolmello diegolmello deleted the feat.slide-drawer branch June 24, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants