-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Timestamp component on the MessageToolBar and Support for Displaying it #988
base: develop
Are you sure you want to change the base?
feat: New Timestamp component on the MessageToolBar and Support for Displaying it #988
Conversation
Video: timestamp.component.working.mp4and other.themes.mp4 |
timestamp.element.mp4 |
Hey @dhairyashiil, it looks like the TimeStamp option is missing in |
Hello @abirc8010 , Thank you for letting me know. I have added the timestamp component in |
What is the use of it ? 🤔 |
We can have support for displaying timestamps, but what is the use of modal which helps you choose timestamps ? |
One major use I can think of is - Timezone Management There must be a reason for this, as Rocket Chat is adding it and considering it for a GSoC project. In Embedded Chat, we primarily include all chat-related features from Rocket Chat, so I thought of adding this here. |
That's great, for now, let's have the support for timestamps but not the modals.. and let's wait for the gsoc project to complete, afterwards based on the implementation, we can think of implementing that here. Talking about timestamps, I've a small idea, Can we make every timestamp dynamic, in prop we can define the type of time stamp dev want and everywhere it will be displayed like that, if no prop is defined - Follow the usual rocket chat timestamp display |
Okay, I will keep support for timestamps and the save modal for later. And yes, we can make every timestamp dynamic, but what would be the use of that? Most people will use the standard timestamps for their respective locations. like only showing time and not date timestamp for messages And if we implement it, we have to make sure the UI remains consistent and looks good. |
Hello @Spiral-Memory, I have created a separate PR (#990) to add support for displaying timestamp messages. Please consider that PR. I would like to use this PR to showcase the feature to Martin and Sing Li Sir. |
Brief Title
Add New Timestamp component on the MessageToolBar and Support for Displaying it
Acceptance Criteria fulfillment
Fixes #987
Video:
aqua.breeze.theme.timestamp.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-988 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.