Fix: deletion of message get simultaneously deleted from the starred modal. #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smritidoneria
changed the title
smritidoneria
changed the title
| @@ -75,6 +83,19 @@ const FileMessage = ({ fileMessage }) => { | |||
| }, | |||
| [messages, RCInstance, dispatchToastMessage] | |||
| ); | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
Why it is here ? Related with files ?
|
Hey @Spiral-Memory , Actually there were similar issue related to the deletion of files from the sidebar, so I fixed that issue too in this pr only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
deletion of the starred message from the main chat interface gets deleted from the starred modal.
Fixes #965
Video/Screenshots
Screen.Recording.2025-02-06.at.11.02.33.AM.mov
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.