fix: No Loading Feedback on Login Form, Causing Unresponsiveness #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +45,10 @@ export default function LoginForm() { | |||
| const handleSubmit = () => { | |||
| if (!userOrEmail) setUserOrEmail(''); | |||
| if (!password) setPassword(''); | |||
| handleLogin(userOrEmail, password); | |||
| setLoading(true); | |||
| handleLogin(userOrEmail, password).finally(() => { | |||
There was a problem hiding this comment.
Can we have it differently ? Instead of using finally here
There was a problem hiding this comment.
@Spiral-Memory
We can put the loading in useRCAuth hook. Then the inside LoginForm we will have:
const { handleLogin, loading } = useRCAuth();
...
const handleSubmit = () => {
if (!userOrEmail) setUserOrEmail('');
if (!password) setPassword('');
handleLogin(userOrEmail, password); // No more setting loading to true and flase here.
};Would that be preferable?
I dont think you meant try ... catch instead of finally?
There was a problem hiding this comment.
@Spiral-Memory We can put the
loadinginuseRCAuthhook. Then the inside LoginForm we will have:const { handleLogin, loading } = useRCAuth(); ... const handleSubmit = () => { if (!userOrEmail) setUserOrEmail(''); if (!password) setPassword(''); handleLogin(userOrEmail, password); // No more setting loading to true and flase here. };Would that be preferable?
I dont think you meant
try ... catchinstead offinally?
Done. I also added loading indication to TOTP form.
Abbas-Askari
force-pushed
the
login-loading
branch
from
568f407 to
5dfed54
Compare
|
Requested changes are completed @Spiral-Memory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add loader to login form
Throbberis added to the login form button while the request is pending and is removed afterwards, making the form more responsive.Fixes #954
Video
VIdeo:
Screencast from 2025-02-03 18-35-47.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-955 after approval.