Add net6.0 target #134
Add net6.0 target #134
Conversation
| @@ -1,6 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>netstandard2.0;net462</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0;net462;net6.0</TargetFrameworks> | |||
There was a problem hiding this comment.
I tried removing it from netstandard2.0 and IIRC it gave an error about not having the reference.
There was a problem hiding this comment.
This actually comes from Namotion.Reflection.Cecil and its need to call XmlDocs APIs with dynamic type to provide both Cecil types and standard CLR types. Is the Namotion.Reflection.Cecil library actually needed anymore?
There was a problem hiding this comment.
It would be great to have a version without dependency on Microsoft.CSharp or reference a more recent version as 4.3 brings a lot of other legacies. See example from our packages lock file
|
I also upgrade Mono.Cecil to version 0.11.5 which has better dependency tree too. |
Directory.Packages.props
Outdated
| @@ -18,7 +18,7 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <GlobalPackageReference Include="GitHubActionsTestLogger" Version="2.3.3" /> | |||
| <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" /> | |||
| <GlobalPackageReference Include="PolySharp" Version="1.13.2" /> | |||
| <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" /> | |||
There was a problem hiding this comment.
According to the docs sourcelink reference is no longer needed if it is using .NET 8 SDK
| <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" /> |
lahma
force-pushed
the
net60-target
branch
3 times, most recently
from
498519d
to
1b81c02
Compare
|
@RicoSuter can we please go forward with this, with this addition I think a new release would be ready that would also fix NSwag upstream issue RicoSuter/NSwag#4842 . |
This removes the need for having
Microsoft.CSharpreference for the NuGet package when consumed from NET 6.0+ project.fixes #145